Autoload Patchwork.php in Composer configuration#44
Open
RubieV wants to merge 1 commit intoantecedent:masterfrom
Open
Autoload Patchwork.php in Composer configuration#44RubieV wants to merge 1 commit intoantecedent:masterfrom
RubieV wants to merge 1 commit intoantecedent:masterfrom
Conversation
Composer nor autoloading seems to not be included in the tests, adding tests around this change might be beneficial.
Owner
|
The manual loading policy is deliberate. Patchwork is first and foremost a testing tool, and tests often reside in the same codebase as the system-under-test. Add the fact that Patchwork slows things down considerably, and now we have a problem: we have to selectively enable Patchwork during testing only, or else we default to negatively impacting the production performance. But let me know if you have an decent solution for the latter :) |
Author
|
I assume you will add a dev-dependency on Patchwork in Composer if you only want Patchwork during tests. Since changing this behavior will have unexpected results for integrations that do manual loading, I would propose a (minor) version increment. |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Composer nor autoloading seems to not be included in the tests, adding tests around this change might be beneficial.